improve component blueprint for octane

[BryanCrotaz]

Cleaned up from #213

[BryanCrotaz]

@chriskrycho let me know when to rebase

[chriskrycho]

Thanks, @BryanCrotaz – will ping you as soon as the other maintainers have had a chance to look at #216 and and #217 and therefore we merge them! (I try to practice good PR hygiene on things I maintain: stuff doesn't go in without a review. 😅)

[chriskrycho]

@BryanCrotaz all right, this is now in need of a merge or rebase—I unfortunately had to touch some of the test files to get things all working again. Once your rebase, though, you should be able to drop a fair bit from this branch. Sorry about the hassle, and thanks again for the contribution! Ping me once you have it working, and we'll get it landed!

[chriskrycho]

Also, fair warning: I'm working on actually getting all the Renovate-bot-powered dependency updates landed today, so you may just want to wait till those land, or you'll have an obnoxious time with rebase/merge issues from package.json and yarn.lock getting out of date.

[BryanCrotaz]

#216 deleted all the component blueprints - was that deliberate?

[MrChocolatine]

@BryanCrotaz , it was apparently:
8c6a016 (#216)

[chriskrycho]

Yep, intentional precisely so that I wouldn't just end up duplicating your work. Re-adding them here is what we need!

[chriskrycho]

…still hammering away at merging those other ones; once all the PRs marked chore(deps) or fix(deps) are closed, then you'll want to merge once more time and we can land this (assuming it's ✅).

[chriskrycho]

And we are all caught up! Rebase and let's do this thing!

[BryanCrotaz]

@chriskrycho can you see why there's a parsing error in the component test template? I've isolated it to the <% if ... %> <% else if ... %> construct but can't see the typo.

SyntaxError: Unexpected token ) (Error in blueprint template: /home/runner/work/ember-cli-typescript-blueprints/ember-cli-typescript-blueprints/blueprints/component-test/qunit-files/__root__/__testType__/__path__/__test__.ts)

[chriskrycho]

Oh man! I have been there. Believe it or not, running in Docker may be substantially faster (for Ember stuff in general). It ends up absorbing a lot of the file system operations in RAM before flushing them to disk (only way it can do stuff in a reasonably speedy way), and… the virtual file system ends up being substantially faster than the Windows native file system. Which, you know, is bonkers. But it’s also true.

One of us will take a peek at this in the next couple days. I have a confirmed COVID exposure so not sure exactly what my own next few days will look like. 😬

[chriskrycho]

This is still wrong—until you replace it with the correct file, stuff is going to be broken. Also, while you're at it, go ahead and remove all the shenanigans around supporting unit tests. As noted on the QUnit test blueprint, we only care here about integration tests, esp. b/c unit tests straight-up don't work with Glimmer components (as it should be!).

[BryanCrotaz]

To clarify, @chriskrycho am I dropping support for anything except glimmer?

[chriskrycho]

No, we should support generating Ember components the same as the core blueprints do. We just don’t want to generate unit tests for them.

[BryanCrotaz]

My brain is melting. So much undocumented stuff in Ember blueprints.

Any idea what the difference between files and native_files is?

And any idea why the test for glimmer being present is succeeding in all tests, even the ember classic components ones?

[BryanCrotaz]

Fancy pairing on this @chriskrycho ?

[chriskrycho]

I’m off this week, and spending what OSS time I have chosen to use on getting our docs finally up to date – see typed-ember/ember-cli-typescript#935 – but perhaps next week.

[MrChocolatine]

Anything new here?

[chriskrycho]

I may be able to help a little in a week or two. And perhaps @jamescdavis might be able to? If not, folks will just have to keep plugging away independently in the meantime.

[knownasilya]

🦜

[lifeart]

[atsjj]

I'm trying to get up-to-speed on what's going on with this PR and seeing if there's anything that the community can do to hop in on and get this stable for merge?

Looks like a rebase is needed as well as just getting tests passing? Not sure if that's all?

[lifeart]

@BryanCrotaz we need you! If I can help somehow, just let me know.

[BryanCrotaz]

I'm out of my depth on the blueprints themselves. I think this needs a pair or group effort. Happy to jump on a zoom with someone and get this all cleaned up. I'm flat out until tomorrow night but could find some time over the weekend or Monday.

Current ember app for this week:

[Alonski]

So... Any ideas if we will ever merge this on or are we waiting for the Typescriptification of Ember for this? 😋

[SergeAstapov]

Considering number of changed files in PR, it's age and number of feedback/concerns, does it make sense to split into pieces?
e.g. work with one entity at a time so we could land things sooner.

Another thought, we may at least update existing files like https://github.com/typed-ember/ember-cli-typescript-blueprints/blob/master/blueprints/model/files/__root__/__path__/__name__.ts in parallel and separately from the (definitely great!) work done here.

[BryanCrotaz]

Happy to help out but I reached beyond the end of my blueprint understanding, so I'd just be happy to see my partial work get finished by someone keen

[BryanCrotaz]

Considering number of changed files in PR, it's age and number of feedback/concerns, does it make sense to split into pieces? e.g. work with one entity at a time so we could land things sooner.

Another thought, we may at least update existing files like https://github.com/typed-ember/ember-cli-typescript-blueprints/blob/master/blueprints/model/files/__root__/__path__/__name__.ts in parallel and separately from the (definitely great!) work done here.

Did any of this happen?