[v4] allow ember-cli-babel to manage TS transpilation #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: it's expected (and unavoidable) that CI will fail here until a version of |
chriskrycho
reviewed
Dec 17, 2019
|
I've opened a draft PR for the |
jamescdavis
requested changes
Dec 23, 2019
There was a problem hiding this comment.
This is working great with emberjs/ember-cli-babel#314 when bumped to 4.0.0-alpha.0. We need to make the test changes from #1007, however, so tests will pass once ember-cli-babel is released and we update.
* remove property initialization order test * upgrade prettier (so it understands class field declarations) * add test for class field declarations * enable optional chaining and nullish coalescing test (bonus)
|
I've updated the tests. This now passes when yarn linked to emberjs/ember-cli-babel#314 and version bumped to |
jamescdavis
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a conversation with some typed-ember folks and @rwjblue, our likely plan moving forward is to have
ember-cli-babelbe responsible for setting up any relevant TypeScript Babel plugin(s) using the presence ofember-cli-typescriptas a trigger. The rough sequence of events I'm picturing:4.0.0-alpha.1release of this package that includes this PR to stop touching Babel config on this sideember-cli-babelthat looks forember-cli-typescript >= 4.0.0-alphaand sets up the appropriate plugins if it finds themember-cli-typescript@4.0.0馃帀Note that this PR is targeting the v4 branch, which we can use as a central point to cut alpha releases and land other changes we want to include in our next major release as we coordinate with ember-cli-babel on the rollout.