(un)feat: remove MU support from the default blueprint #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescdavis
approved these changes
Aug 27, 2019
| ], | ||
| "in-repo-b/*": [ | ||
| "tests/dummy/lib/in-repo-b/addon/*" | ||
| ] |
| describe('module unification', function() { | ||
| it('generates .d.ts files from the src tree', async () => { | ||
| describe('custom project layout', function() { | ||
| it('generates .d.ts files from the specified source tree', async () => { |
jamescdavis
reviewed
Aug 28, 2019
| - Removes support in the default blueprint for initializing new Module Unification projects, in line with [MU's removal][MU] from Ember's roadmap in favor of other directions. Existing MU projects should continue to build and typecheck according to the local `tsconfig.json`. ([#826](https://github.com/typed-ember/ember-cli-typescript/pull/826)) | ||
|
|
||
| [MU]: https://blog.emberjs.com/2019/03/11/update-on-module-unification-and-octane.html | ||
|
|
There was a problem hiding this comment.
👍
lol, I'm always asking for changelog in PRs at work, but didn't think to require that here 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the portion of #806 corresponding to
ember-cli-typescriptitself — the remainder of the change will be in the blueprints package.We still support building/typechecking/generating
.d.tsfiles for nonstandard project layouts, but the default blueprint will no longer support configuring new MU projects for TypeScript automatically.