Support nullish coalescing and optional chaining with TS 3.7 #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll test it with the 3.7 RC, and we should be fine to bump to 3.7 when it's out given the specific way we're using TS in the build pipeline, right? |
|
Yep. I suppose we could even bump to the 3.7 rc now, since we have explicit CI coverage for the current release version as well. |
|
Yeah, that makes sense as well. I'd be okay deferring this till it's officially out Just In Case™, but I don't have any strong objection to using the RC on |
|
@dfreeman can you rebased this, and we can land it on master for people to experiment with? 🙏 |
dfreeman
force-pushed
the
ts-3.7-plugins
branch
from
ff8cc03
to
df46feb
Compare
|
Got a green one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ember-cli-typescript to add the Babel plugins for nullish coalescing and optional chaining if it detects a new enough project TypeScript version.
Until we update to TS 3.7 in this repo, though, I'm not 100% sure of a good way to test this (short of moving to a fancier multi-package workspaces-style testing setup, which we may eventually want to do anyway, but seems like a lot for this particular change). Definitely open to thoughts there.
I'm also assuming CI will fail until we get our Windows woes sorted 😢