fix: ensure we register Babel plugins with their full path #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again: disabling Windows tests and merging. 😢 |
|
I have now reenabled Windows tests for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're specifying just the name of the Babel plugins we register, which works as long as some version of those plugins gets hoisted and is available to
requirefrom the host application's perspective. This fails, though, if the hoisting doesn't happen, or if the package is linked, or other dependency shenanigans are in play.This PR adds our plugins by their full path rather than just by name (the helpers we use already account for either of these formats, so nothing else should need to change).