Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out all we need to do here is set the root URL to ''.
After merging this PR, the steps for enabling the custom domain are:
master
(and update latest):ADDON_DOCS_UPDATE_LATEST=true ember deploy production
ember-cli-typescript.com
octane-docs
branch so it continues to work too:git checkout octane-docs && git merge master && ember deploy production
I've tested this on my fork and then removed the custom domain there so typed-ember can pick it up. DNS is already configured for github pages.
Once re-deployed & configured, docs will be available at https://ember-cli-typescript.com and https://typed-ember.github.io/ember-cli-typescript/ will redirect there.
Also, ember-cli-addon-docs has a bug, which has been fixed with ember-learn/ember-cli-addon-docs#412, but not released yet, so we need to pin to a sha to re-deploy and have our blue brand customization work. We're already doing this in the
octane-docs
branch. This will just bring it intomaster
so we can re-deploymaster
too.