Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs custom domain #993

Merged
merged 2 commits into from
Dec 7, 2019
Merged

Conversation

jamescdavis
Copy link
Member

Turns out all we need to do here is set the root URL to ''.

After merging this PR, the steps for enabling the custom domain are:

  1. re-deploy master (and update latest):
    ADDON_DOCS_UPDATE_LATEST=true ember deploy production
  2. immediately enable the custom domain here by entering:
    ember-cli-typescript.com
  3. update and re-deploy the octane-docs branch so it continues to work too:
    git checkout octane-docs && git merge master && ember deploy production

I've tested this on my fork and then removed the custom domain there so typed-ember can pick it up. DNS is already configured for github pages.

Once re-deployed & configured, docs will be available at https://ember-cli-typescript.com and https://typed-ember.github.io/ember-cli-typescript/ will redirect there.

Also, ember-cli-addon-docs has a bug, which has been fixed with ember-learn/ember-cli-addon-docs#412, but not released yet, so we need to pin to a sha to re-deploy and have our blue brand customization work. We're already doing this in the octane-docs branch. This will just bring it into master so we can re-deploy master too.

@jamescdavis jamescdavis merged commit 3fb7faf into typed-ember:master Dec 7, 2019
@jamescdavis jamescdavis deleted the docs-custom-domain branch December 7, 2019 15:38
@chriskrycho
Copy link
Member

💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants