Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate packages.md even if groups used #514

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

boneskull
Copy link
Contributor

Closes #471


I have no idea if this is correct, and I didn't change any tests to support it; please let me know if a) this is correct, and b) if so, where I can add a test?

thanks!

@tgreyuk tgreyuk merged commit 766b388 into typedoc2md:next Nov 29, 2023
1 check passed
@tgreyuk
Copy link
Member

tgreyuk commented Nov 29, 2023

Thanks. This is published in typedoc-plugin-markdown@4.0.0-next.32 .

Currently a bunch of snapshot tests run against various combination of options and they are all passing. This use-case was not covered and I have no idea why that condition was in there. I'll get some docs together to explain how the tests (currently) work. A contributing guide is on its way but still tidying up a few bits.

@boneskull
Copy link
Contributor Author

@tgreyuk As long as I have your attention--what is the equivalent of publicPath in v4.x? 😄

@tgreyuk
Copy link
Member

tgreyuk commented Nov 30, 2023

@boneskull This option is now included in typedoc-plugin-markdown@4.0.0-next.33 - same behaviour as v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants