Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE for socket writes on Node.js 19 #3178

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fix NPE for socket writes on Node.js 19 #3178

merged 1 commit into from
Mar 23, 2023

Conversation

armanbilge
Copy link
Member

This feels like a Node.js bug.

@armanbilge armanbilge changed the title Fix NPE for macOS unix sockets Fix NPE for unix sockets Mar 23, 2023
@armanbilge
Copy link
Member Author

Aha, this is not specific to macOS. This is a Node.js 19 issue, which is what brew installs by default. I just replicated on Ubuntu.

@armanbilge
Copy link
Member Author

@armanbilge armanbilge changed the title Fix NPE for unix sockets Fix NPE for socket writes on Node.js 19 Mar 23, 2023
@mpilquist mpilquist merged commit 599de2a into typelevel:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@armanbilge @mpilquist