Optmize interop.flow.StreamSubscriber.onNext #3387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalmungSan
force-pushed
the
optimize-flow-interop
branch
from
72b0be9
to
8234158
Compare
BalmungSan
commented
Feb 12, 2024
| @@ -109,6 +109,7 @@ private[flow] final class StreamSubscription[F[_], A] private ( | |||
| // if we were externally canceled, this is handled below | |||
| F.unit | |||
| } | |||
| .mask | |||
There was a problem hiding this comment.
Related to #3384
BalmungSan
commented
Mar 29, 2024
Comment on lines
+47
to
+51
| @Param(Array("1024", "5120", "10240")) | ||
| var totalElements: Int = _ | ||
|
|
||
| @Param(Array("1000")) | ||
| var iterations: Int = _ |
There was a problem hiding this comment.
Are these parameters okay?
Comment on lines
+63
to
+79
| override final def request(n: Long): Unit = { | ||
| Future { | ||
| var j = 0 | ||
| while (j < n && i < totalElements && !canceled) { | ||
| subscriber.onNext(i) | ||
| i += 1 | ||
| j += 1 | ||
| } | ||
|
|
||
| if (i == totalElements || canceled) { | ||
| subscriber.onComplete() | ||
| } | ||
| }(global.compute) | ||
|
|
||
| // Discarding the Future so it runs in the background. | ||
| () | ||
| } |
There was a problem hiding this comment.
@armanbilge is this close to the idea that you had in mind originally?
Comment on lines
+90
to
+91
| val program = | ||
| stream.compile.toVector |
There was a problem hiding this comment.
I was not sure what was the best way to collect the results.
My other two options were doing something like compile.fold(0)(_ + _) or a .foreach(_ => IO.unit).compile.drain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
reactive-streamsspec mentions that all calls must be done "serially" these changes optimize the tight loop of multiple consequentialonNextcalls.