Do not use deprecated -target option on 2.13.9+
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satorg
approved these changes
Oct 9, 2022
|
I wonder though, should we attempt to address this change in options between v2.13.8 and v2.13.9 in our shiny scala-options version of the future? It's one more thing to think about 🤔 |
Yes, actually this is exactly my hope for scalac-options :) |
|
Thanks for the review, I really appreciate having a few other eyes around 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error, seen in builds using the
tlJdkReleaseoption with Scala 2.13.9.Relevant PR:
-releasemore useful, deprecate-target, align with Scala 3 scala/scala#9982