fix: properly override database url properties (#6247)

* fix: properly override database url properties

Closes #4878

* test: add test for overriding url options

src/driver/DriverUtils.ts

@@ -28,7 +28,7 @@ export class DriverUtils {
             if (buildOptions && buildOptions.useSid) {
                 urlDriverOptions.sid = parsedUrl.database;
             }
-            return Object.assign({}, options, urlDriverOptions);
+            return Object.assign({}, urlDriverOptions, options);
         }
         return Object.assign({}, options);
     }

test/github-issues/4878/issue-4878.ts

@@ -0,0 +1,19 @@
+import { DriverUtils } from "../../../src/driver/DriverUtils";
+import { expect } from "chai";
+
+describe("github issues > #4878 URL Connection string not overridden by supplied options", () => {
+    it("should override url-built options with user-supplied options", () => {
+        const obj: any = {
+            username: "user",
+            password: "password",
+            host: "host",
+            database: "database",
+            port: 8888
+        };
+
+        const url = `postgres://url_user:${obj.password}@${obj.host}:${obj.port}/${obj.database}`;
+        obj.url = url;
+        const options = DriverUtils.buildDriverOptions(obj);
+        expect(options.username).to.eql(obj.username);
+    });
+});