feat: add serviceName option for oracle connections (#8021)

typeorm · Aug 4, 2021 · 37bd012 · 37bd012
1 parent ca26297
commit 37bd012
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/driver/oracle/OracleConnectionCredentialsOptions.ts b/src/driver/oracle/OracleConnectionCredentialsOptions.ts
@@ -37,7 +37,12 @@ export interface OracleConnectionCredentialsOptions {
      * Connection SID.
      */
     readonly sid?: string;
-
+
+    /**
+     * Connection Service Name.
+     */
+    readonly serviceName?: string;
+
     /**
      * Embedded TNS Connection String
      */

diff --git a/src/driver/oracle/OracleDriver.ts b/src/driver/oracle/OracleDriver.ts
@@ -813,6 +813,10 @@ export class OracleDriver implements Driver {
                 connectData += `(SID=${credentials.sid})`;
             }
 
+            if (credentials.serviceName) {
+                connectData += `(SERVICE_NAME=${credentials.serviceName})`
+            }
+
             const connectString = `(DESCRIPTION=(ADDRESS=${address})(CONNECT_DATA=${connectData}))`;
             Object.assign(credentials, { connectString });
         }