fix: resolve duplicate subscriber updated columns (#9958)

Closes: #9948

src/persistence/SubjectChangedColumnsComputer.ts

@@ -166,7 +166,10 @@ export class SubjectChangedColumnsComputer {
                     if (normalizedValue === databaseValue) return
                 }
             }
-            subject.diffColumns.push(column)
+
+            if (!subject.diffColumns.includes(column))
+                subject.diffColumns.push(column)
+
             subject.changeMaps.push({
                 column: column,
                 value: entityValue,

test/github-issues/9948/entity/Post.ts

@@ -0,0 +1,13 @@
+import { Column, Entity, PrimaryGeneratedColumn } from "../../../../src"
+
+@Entity()
+export class Post {
+    @PrimaryGeneratedColumn()
+    id: number
+
+    @Column()
+    name: string
+
+    @Column({ default: 0 })
+    updatedNameColumnsCount: number
+}

test/github-issues/9948/issue-9948.ts

@@ -0,0 +1,40 @@
+import "reflect-metadata"
+import {
+    createTestingConnections,
+    closeTestingConnections,
+    reloadTestingDatabases,
+} from "../../utils/test-utils"
+import { DataSource } from "../../../src/data-source/DataSource"
+import { expect } from "chai"
+import { Post } from "./entity/Post"
+
+describe("github issues > #9948 Subscribers with both 'beforeUpdate' and 'afterUpdate' methods defined cause duplicate 'updatedColumn' entries", () => {
+    let dataSources: DataSource[]
+    before(
+        async () =>
+            (dataSources = await createTestingConnections({
+                entities: [__dirname + "/entity/*{.js,.ts}"],
+                subscribers: [__dirname + "/subscriber/*{.js,.ts}"],
+                schemaCreate: true,
+                dropSchema: true,
+            })),
+    )
+    beforeEach(() => reloadTestingDatabases(dataSources))
+    after(() => closeTestingConnections(dataSources))
+
+    it("should not duplicate update column", () =>
+        Promise.all(
+            dataSources.map(async (dataSource) => {
+                const manager = dataSource.manager
+
+                const initialPost = new Post()
+                initialPost.name = "post-init"
+                await manager.save(initialPost)
+
+                initialPost.name = "post-update"
+                const updatedPost = await manager.save(initialPost)
+
+                expect(updatedPost.updatedNameColumnsCount).to.be.eq(1)
+            }),
+        ))
+})

test/github-issues/9948/subscriber/PostSubscriber.ts

@@ -0,0 +1,31 @@
+import {
+    EntitySubscriberInterface,
+    EventSubscriber,
+    UpdateEvent,
+} from "../../../../src"
+import { Post } from "../entity/Post"
+
+@EventSubscriber()
+export class PostSubscriber implements EntitySubscriberInterface {
+    listenTo(): string | Function {
+        return Post
+    }
+
+    beforeUpdate(event: UpdateEvent<Post>): void | Promise<Post> {
+        event.entity!.updatedNameColumnsCount = event.updatedColumns.reduce(
+            (p, c) => {
+                return p + (c.propertyName === "name" ? 1 : 0)
+            },
+            0,
+        )
+    }
+
+    afterUpdate(event: UpdateEvent<Post>): void | Promise<Post> {
+        event.entity!.updatedNameColumnsCount = event.updatedColumns.reduce(
+            (p, c) => {
+                return p + (c.propertyName === "name" ? 1 : 0)
+            },
+            0,
+        )
+    }
+}