Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: coerce port to number in ConnectionOptionsEnvReader (#6786)
the expected type of `port` in all drivers is a number - and in MSSQL this is a problem as the underlying driver does not properly handle a string port - so we have to parseInt closes #6781
- Loading branch information
55fbb69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As shown in the below compiled code, seems issue still exists? @imnotjames
port: PlatformTools_1.PlatformTools.getEnvVariable("TYPEORM_PORT"),
55fbb69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are you seeing that?
At this time this code hasn't been released yet.
55fbb69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh Right, @imnotjames sorry. I am seeing it in 0.2.6. I am currently bypassing it by removing the port from .env.
Do you know when is this going to be released?
55fbb69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! I was just worried I somehow messed something up :)
I don't know if there's an exact timeline for another release. I think the goal is within the next few weeks