Use optimized path in compareIds() also when .id has type "number"

typeorm · Feb 23, 2020 · 7adc0ab · 7adc0ab
1 parent 4bd2e34
commit 7adc0ab
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/util/OrmUtils.ts b/src/util/OrmUtils.ts
@@ -130,8 +130,8 @@ export class OrmUtils {
 
         // Optimized version for the common case
         if (
-            typeof firstId.id === "string" &&
-            typeof secondId.id === "string" &&
+            (typeof firstId.id === "string" || typeof firstId.id === "number") &&
+            (typeof secondId.id === "string" || typeof secondId.id === "number") &&
             Object.keys(firstId).length === 1 &&
             Object.keys(secondId).length === 1
         ) {