Skip to content

Commit

Permalink
fix: SelectQueryBuilder builds incorrectly escaped alias in Oracle wh…
Browse files Browse the repository at this point in the history
…en used on entity with composite key (#9668)

* Update SelectQueryBuilder.ts

Bug fix, In case a unique alias is created in first query then result was not getting mapped properly.

* lint fix

---------

Co-authored-by: Dmitry Zotov <dmzt08@gmail.com>
  • Loading branch information
Alankarsharma and AlexMesser committed Apr 15, 2023
1 parent f6a3ce7 commit 83c6c0e
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions src/query-builder/SelectQueryBuilder.ts
Expand Up @@ -3491,10 +3491,14 @@ export class SelectQueryBuilder<Entity extends ObjectLiteral>
return metadata.primaryColumns
.map((primaryColumn) => {
const paramKey = `orm_distinct_ids_${index}_${primaryColumn.databaseName}`
const paramKeyResult =
DriverUtils.buildAlias(
this.connection.driver,
"ids_" + mainAliasName,
primaryColumn.databaseName,
)
parameters[paramKey] =
result[
`ids_${mainAliasName}_${primaryColumn.databaseName}`
]
result[paramKeyResult]
return `${mainAliasName}.${primaryColumn.propertyPath}=:${paramKey}`
})
.join(" AND ")
Expand Down

0 comments on commit 83c6c0e

Please sign in to comment.