fix: NativescriptQueryRunner's query method fails when targeting es20…

…17 (#8182)
typeorm · Oct 6, 2021 · 8615733 · 8615733
1 parent dd94c9d
commit 8615733
Showing 1 changed file with 29 additions and 24 deletions.
diff --git a/src/driver/nativescript/NativescriptQueryRunner.ts b/src/driver/nativescript/NativescriptQueryRunner.ts
@@ -31,51 +31,56 @@ export class NativescriptQueryRunner extends AbstractSqliteQueryRunner {
      * Executes a given SQL query.
      */
     async query(query: string, parameters?: any[], useStructuredResult = false): Promise<any> {
-        if (this.isReleased)
+
+        if (this.isReleased) {
             throw new QueryRunnerAlreadyReleasedError();
+        }
 
         const connection = this.driver.connection;
 
-        return new Promise( (ok, fail) => {
+        return new Promise(async (ok, fail) => {
+
+            const databaseConnection = await this.connect();
             const isInsertQuery = query.substr(0, 11) === "INSERT INTO";
+            connection.logger.logQuery(query, parameters, this);
 
-            const handler = function (err: any, raw: any) {
+            const handler = (err: any, raw: any) => {
 
                 // log slow queries if maxQueryExecution time is set
                 const maxQueryExecutionTime = this.driver.options.maxQueryExecutionTime;
                 const queryEndTime = +new Date();
                 const queryExecutionTime = queryEndTime - queryStartTime;
-                if (maxQueryExecutionTime && queryExecutionTime > maxQueryExecutionTime)
+
+                if (maxQueryExecutionTime && queryExecutionTime > maxQueryExecutionTime) {
                     connection.logger.logQuerySlow(queryExecutionTime, query, parameters, this);
-
+                }
+
                 if (err) {
                     connection.logger.logQueryError(err, query, parameters, this);
                     fail(new QueryFailedError(query, parameters, err));
-                } else {
-                    const result = new QueryResult();
+                }
 
-                    result.raw = raw;
+                const result = new QueryResult();
+                result.raw = raw;
 
-                    if (!isInsertQuery && Array.isArray(raw)) {
-                        result.records = raw;
-                    }
+                if (!isInsertQuery && Array.isArray(raw)) {
+                    result.records = raw;
+                }
 
-                    if (useStructuredResult) {
-                        ok(result);
-                    } else {
-                        ok(result.raw);
-                    }
+                if (useStructuredResult) {
+                    ok(result);
+                } else {
+                    ok(result.raw);
                 }
+
             };
-            this.driver.connection.logger.logQuery(query, parameters, this);
             const queryStartTime = +new Date();
-            this.connect().then(databaseConnection => {
-                if (isInsertQuery) {
-                    databaseConnection.execSQL(query, parameters, handler);
-                } else {
-                    databaseConnection.all(query, parameters, handler);
-                }
-            });
+
+            if (isInsertQuery) {
+                databaseConnection.execSQL(query, parameters, handler);
+            } else {
+                databaseConnection.all(query, parameters, handler);
+            } 
         });
     }