perf: Optimized version of EntityMetadata#compareIds() for the common…

… case
typeorm · Jan 26, 2020 · 8658ad7 · 8658ad7
1 parent 6c6bde7
commit 8658ad7
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/metadata/EntityMetadata.ts b/src/metadata/EntityMetadata.ts
@@ -746,6 +746,16 @@ export class EntityMetadata {
         if (firstId === undefined || firstId === null || secondId === undefined || secondId === null)
             return false;
 
+        // Optimized version for the common case
+        if (
+          typeof firstId.id === "string" &&
+          typeof secondId.id === "string" &&
+          Object.keys(firstId).length === 1 &&
+          Object.keys(secondId).length === 1
+        ) {
+            return firstId.id === secondId.id;
+        }
+
         return OrmUtils.deepCompare(firstId, secondId);
     }