-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: support multiple row insert on oracle (#6927)
change generated insert query to allow inserting an array of objects to oracle fixes: #2434
- Loading branch information
Showing
4 changed files
with
149 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { CreateDateColumn, Column } from "../../../../src"; | ||
| import { PrimaryGeneratedColumn } from "../../../../src/decorator/columns/PrimaryGeneratedColumn"; | ||
| import { Entity } from "../../../../src/decorator/entity/Entity"; | ||
|
|
||
| @Entity("ITEM") | ||
| export class Item { | ||
| @PrimaryGeneratedColumn("uuid") | ||
| id: number; | ||
|
|
||
| @CreateDateColumn() | ||
| date: Date; | ||
|
|
||
| @Column() | ||
| itemName: string; | ||
|
|
||
| @Column({nullable: true}) | ||
| itemDescription?: string; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import {Entity} from "../../../../src/decorator/entity/Entity"; | ||
| import {PrimaryColumn} from "../../../../src/decorator/columns/PrimaryColumn"; | ||
| import {Column} from "../../../../src/decorator/columns/Column"; | ||
|
|
||
| @Entity({name: "POST"}) | ||
| export class Post { | ||
|
|
||
| @PrimaryColumn() | ||
| id: number; | ||
|
|
||
| @Column({ nullable: true }) | ||
| title?: string; | ||
|
|
||
| @Column({name: "named_column", nullable: true}) | ||
| namedColumn?: string; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| import "reflect-metadata"; | ||
| import {Connection} from "../../../src"; | ||
| import {Post} from './entity/Post'; | ||
| import {Item} from './entity/Item'; | ||
| import { closeTestingConnections, reloadTestingDatabases, createTestingConnections } from '../../utils/test-utils'; | ||
| import { expect } from 'chai'; | ||
|
|
||
| describe("github issues > #2434 QueryBuilder insert for Oracle failed", () => { | ||
| let connections: Connection[] = []; | ||
| before(async () => connections = await createTestingConnections({ | ||
| entities: [__dirname + "/entity/*{.js,.ts}"], | ||
| enabledDrivers: ["oracle"] | ||
| })); | ||
| beforeEach(() => reloadTestingDatabases(connections)); | ||
| after(() => closeTestingConnections(connections)); | ||
|
|
||
| it("should insert multiple rows with QueryBuilder", () => Promise.all(connections.map(async connection => { | ||
| const result = await connection.createQueryBuilder() | ||
| .insert() | ||
| .into(Post) | ||
| .values([ | ||
| {id: 5, title: "title 1"}, | ||
| {id: 6}, | ||
| ]) | ||
| .execute(); | ||
| expect(result.raw).to.be.equal(2); | ||
| expect(result.identifiers).to.deep.equal([ | ||
| {id: 5}, | ||
| {id: 6}, | ||
| ]); | ||
| }))); | ||
|
|
||
| it("should throw ORA-00001 error if constraint violated when inserting multiple rows", () => Promise.all(connections.map(async connection => { | ||
| try { | ||
| await connection.createQueryBuilder() | ||
| .insert() | ||
| .into(Post) | ||
| .values([ | ||
| {id: 6, title: "title 3"}, | ||
| {id: 6}, | ||
| ]) | ||
| .execute(); | ||
| } catch(err) { | ||
| expect(err.message).to.contain("ORA-00001"); | ||
| } | ||
| }))); | ||
|
|
||
| it("should insert multiple rows of entity with generated columns with QueryBuilder", () => Promise.all(connections.map(async connection => { | ||
| const result = await connection.createQueryBuilder() | ||
| .insert() | ||
| .into(Item) | ||
| .values([ | ||
| {itemName: "item name 1"}, | ||
| {itemName: "item name 2"}, | ||
| ]) | ||
| .execute(); | ||
| expect(result.raw).to.be.equal(2); | ||
| const items = await connection.getRepository(Item).find(); | ||
| expect(items.length).to.be.equal(2); | ||
| }))); | ||
|
|
||
| it("should still insert one row with QueryBuilder", () => Promise.all(connections.map(async connection => { | ||
| const result = await connection.createQueryBuilder() | ||
| .insert() | ||
| .into(Item) | ||
| .values({itemName: "item name 20"}) | ||
| .execute(); | ||
| expect(result.identifiers.length).to.be.equal(1); | ||
| const items = await connection.getRepository(Item).find(); | ||
| expect(items[0].itemName).to.be.equal("item name 20"); | ||
| }))); | ||
|
|
||
| it("should still insert multiple rows with save", () => Promise.all(connections.map(async connection => { | ||
| const result = await connection.getRepository(Post).save([ | ||
| {id: 8, namedColumn: "test col 1"}, | ||
| {id: 9, title: "title id 9"}, | ||
| ]); | ||
| expect(result).to.deep.equal([ | ||
| {id: 8, title: null, namedColumn: "test col 1"}, | ||
| {id: 9, title: "title id 9", namedColumn: null}, | ||
| ]); | ||
|
|
||
| }))); | ||
|
|
||
| it("should still insert one row with save", () => Promise.all(connections.map(async connection => { | ||
| const result = await connection.getRepository(Post).save({id: 10}); | ||
| expect(result).to.deep.equal({id: 10, title: null, namedColumn: null}); | ||
| }))); | ||
|
|
||
| }); |