Reverts throwing error as that won't work.

typeorm · Aug 18, 2020 · b4c313b · b4c313b
1 parent cf4578f
commit b4c313b
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 18 deletions.
diff --git a/src/driver/sqlite-abstract/AbstractSqliteDriver.ts b/src/driver/sqlite-abstract/AbstractSqliteDriver.ts
@@ -315,6 +315,7 @@ export abstract class AbstractSqliteDriver implements Driver {
             value = DateUtils.stringToSimpleArray(value);
 
         } else if (columnMetadata.type === "simple-json") {
+            console.log(value, typeof value);
             value = DateUtils.stringToSimpleJson(value);
 
         } else if ( columnMetadata.type === "simple-enum" ) {

diff --git a/src/error/SimpleJsonIsNotAStringError.ts b/src/error/SimpleJsonIsNotAStringError.ts
diff --git a/src/util/DateUtils.ts b/src/util/DateUtils.ts
@@ -1,5 +1,4 @@
 import { ColumnMetadata } from "../metadata/ColumnMetadata";
-import { SimpleJsonIsNotAStringError } from "../error/SimpleJsonIsNotAStringError";
 
 /**
  * Provides utilities to transform hydrated and persisted data.
@@ -176,10 +175,7 @@ export class DateUtils {
     }
 
     static stringToSimpleJson(value: any) {
-        if (value && typeof value !== "string") {
-            throw new SimpleJsonIsNotAStringError(value);
-        }
-        return value !== "" ? JSON.parse(value) : value;
+        return value === "string" ? JSON.parse(value) : value;
     }
 
     static simpleEnumToString(value: any) {

diff --git a/test/github-issues/5501/entity/Post.ts b/test/github-issues/5501/entity/Post.ts
@@ -12,5 +12,4 @@ export class Post {
         nullable: true
     })
     jsonField: any;
-
 }