fix: bugfixes introduced in 0.3.0 (#8764)

* fixes #8762; #8759; #8758; #8757;

docs/custom-repository.md

@@ -34,7 +34,7 @@ In order to extend `UserRepository` functionality you can use `.extend` method o
 ```typescript
 // user.repository.ts
 export const UserRepository = dataSource.getRepository(User).extend({
-    findByName(firstName: string, lastName: string) {
+    findOneByName(firstName: string, lastName: string) {
         return this.createQueryBuilder("user")
             .where("user.firstName = :firstName", { firstName })
             .andWhere("user.lastName = :lastName", { lastName })

src/connection/options-reader/ConnectionOptionsEnvReader.ts

@@ -77,17 +77,6 @@ export class ConnectionOptionsEnvReader {
                     "TYPEORM_MAX_QUERY_EXECUTION_TIME",
                 ),
                 debug: PlatformTools.getEnvVariable("TYPEORM_DEBUG"),
-                cli: {
-                    entitiesDir: PlatformTools.getEnvVariable(
-                        "TYPEORM_ENTITIES_DIR",
-                    ),
-                    migrationsDir: PlatformTools.getEnvVariable(
-                        "TYPEORM_MIGRATIONS_DIR",
-                    ),
-                    subscribersDir: PlatformTools.getEnvVariable(
-                        "TYPEORM_SUBSCRIBERS_DIR",
-                    ),
-                },
                 cache: this.transformCaching(),
                 uuidExtension: PlatformTools.getEnvVariable(
                     "TYPEORM_UUID_EXTENSION",

src/data-source/BaseDataSourceOptions.ts

@@ -204,24 +204,4 @@ export interface BaseDataSourceOptions {
                */
               readonly ignoreErrors?: boolean
           }
-
-    /**
-     * CLI settings.
-     */
-    readonly cli?: {
-        /**
-         * Directory where entities should be created by default.
-         */
-        readonly entitiesDir?: string
-
-        /**
-         * Directory where migrations should be created by default.
-         */
-        readonly migrationsDir?: string
-
-        /**
-         * Directory where subscribers should be created by default.
-         */
-        readonly subscribersDir?: string
-    }
 }

src/data-source/DataSource.ts

@@ -196,20 +196,6 @@ export class DataSource {
      */
     setOptions(options: Partial<DataSourceOptions>): this {
         Object.assign(this.options, options)
-
-        this.logger = new LoggerFactory().create(
-            this.options.logger,
-            this.options.logging,
-        )
-        this.driver = new DriverFactory().create(this)
-        this.namingStrategy =
-            options.namingStrategy || new DefaultNamingStrategy()
-        this.queryResultCache = options.cache
-            ? new QueryResultCacheFactory(this).create()
-            : undefined
-
-        // build all metadatas to make sure options are valid
-        // await this.buildMetadatas();
         return this
     }
 
@@ -681,5 +667,13 @@ export class DataSource {
             ),
             this.driver,
         )
+
+        // set current data source to the entities
+        for (let entityKey in flattenedEntities) {
+            const entity = flattenedEntities[entityKey]
+            if (InstanceChecker.isBaseEntityConstructor(entity)) {
+                entity.useDataSource(this)
+            }
+        }
     }
 }

src/entity-manager/EntityManager.ts

@@ -1347,7 +1347,14 @@ export class EntityManager {
     withRepository<Entity, R extends Repository<Entity>>(repository: R): R {
         const repositoryConstructor =
             repository.constructor as typeof Repository
-        return new repositoryConstructor(repository.target, this) as R
+        const { target, manager, queryRunner, ...otherRepositoryProperties } =
+            repository
+        return Object.assign(
+            new repositoryConstructor(repository.target, this) as R,
+            {
+                ...otherRepositoryProperties,
+            },
+        )
     }
 
     /**