fix: .save repository method not returning generated uuids for auro…

…ra-postgres (#8825) * fix: fixed .save repository method not returning generated uuids for aurora driver * fix(aurora-postgres): fixed .save repository method not returning generated uuids for aurora driver
typeorm · Mar 30, 2022 · ed06f4c · ed06f4c
1 parent c5dfc11
commit ed06f4c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/driver/DriverUtils.ts b/src/driver/DriverUtils.ts
@@ -32,6 +32,10 @@ export class DriverUtils {
         return ["mysql", "mariadb"].includes(driver.options.type)
     }
 
+    static isPostgresFamily(driver: Driver): boolean {
+        return ["postgres", "aurora-postgres"].includes(driver.options.type)
+    }
+
     /**
      * Normalizes and builds a new driver options.
      * Extracts settings from connection url and sets to a new options object.

diff --git a/src/query-builder/InsertQueryBuilder.ts b/src/query-builder/InsertQueryBuilder.ts
@@ -412,7 +412,7 @@ export class InsertQueryBuilder<Entity> extends QueryBuilder<Entity> {
 
         if (
             this.alias !== this.getMainTableName() &&
-            this.connection.driver.options.type === "postgres"
+            DriverUtils.isPostgresFamily(this.connection.driver)
         ) {
             query += ` AS "${this.alias}"`
         }
@@ -507,7 +507,7 @@ export class InsertQueryBuilder<Entity> extends QueryBuilder<Entity> {
                 if (
                     Array.isArray(overwrite) &&
                     skipUpdateIfNoValuesChanged &&
-                    this.connection.driver.options.type === "postgres"
+                    DriverUtils.isPostgresFamily(this.connection.driver)
                 ) {
                     query += ` WHERE (`
                     query += overwrite
@@ -560,7 +560,7 @@ export class InsertQueryBuilder<Entity> extends QueryBuilder<Entity> {
         // add RETURNING expression
         if (
             returningExpression &&
-            (this.connection.driver.options.type === "postgres" ||
+            (DriverUtils.isPostgresFamily(this.connection.driver) ||
                 this.connection.driver.options.type === "oracle" ||
                 this.connection.driver.options.type === "cockroachdb" ||
                 DriverUtils.isMySQLFamily(this.connection.driver))
@@ -829,8 +829,9 @@ export class InsertQueryBuilder<Entity> extends QueryBuilder<Entity> {
                                 expression += `${geomFromText}(${paramName})`
                             }
                         } else if (
-                            this.connection.driver.options.type ===
-                                "postgres" &&
+                            DriverUtils.isPostgresFamily(
+                                this.connection.driver,
+                            ) &&
                             this.connection.driver.spatialTypes.indexOf(
                                 column.type,
                             ) !== -1