fix: entity to be Partial<Entity> | undefined in UpdateEvent (#…

…7783)
typeorm · Jul 9, 2021 · f033045 · f033045
1 parent 8436fdb
commit f033045
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 7 deletions.
diff --git a/src/subscriber/event/UpdateEvent.ts b/src/subscriber/event/UpdateEvent.ts
@@ -30,7 +30,7 @@ export interface UpdateEvent<Entity> {
     /**
      * Updating entity.
      */
-    entity: Entity;
+    entity: Partial<Entity> | undefined;
 
     /**
      * Metadata of the entity.

diff --git a/test/github-issues/1369/subscriber/AbstractEntitySubscriber.ts b/test/github-issues/1369/subscriber/AbstractEntitySubscriber.ts
@@ -10,9 +10,11 @@ export class AbstractEntitySubscriber implements EntitySubscriberInterface<Abstr
     this.updateFullName(event.entity);
   }
   async beforeUpdate(event: UpdateEvent<AbstractEntity>) {
-    this.updateFullName(event.entity);
+    if(event.entity) {
+      this.updateFullName(event.entity);
+    }
   }
-  updateFullName(o: AbstractEntity) {
+  updateFullName(o: Partial<AbstractEntity>) {
     o.fullname = o.firstname + " " + o.lastname;
   }
 }
diff --git a/test/github-issues/3256/subscriber/PostSubscriber.ts b/test/github-issues/3256/subscriber/PostSubscriber.ts
@@ -12,7 +12,9 @@ export class PostSubscriber implements EntitySubscriberInterface<Post> {
     }
 
     async beforeUpdate(event: UpdateEvent<Post>) {
-        event.entity.updated = true;
+        if(event.entity) {
+            event.entity.updated = true;
+        }
     }
 
 }
diff --git a/test/other-issues/entity-change-in-subscribers/subscriber/PostSubscriber.ts b/test/other-issues/entity-change-in-subscribers/subscriber/PostSubscriber.ts
@@ -8,8 +8,10 @@ export class PostSubscriber implements EntitySubscriberInterface<Post> {
     }
 
     beforeUpdate(event: UpdateEvent<Post>) {
-        event.entity.updatedColumns = event.updatedColumns.length;
-        event.entity.updatedRelations = event.updatedRelations.length;
+        if(event.entity) {
+            event.entity.updatedColumns = event.updatedColumns.length;
+            event.entity.updatedRelations = event.updatedRelations.length;
+        }
     }
 
 }
diff --git a/test/other-issues/mongodb-entity-change-in-subscribers/subscriber/PostSubscriber.ts b/test/other-issues/mongodb-entity-change-in-subscribers/subscriber/PostSubscriber.ts
@@ -8,7 +8,9 @@ export class PostSubscriber implements EntitySubscriberInterface<Post> {
     }
 
     beforeUpdate(event: UpdateEvent<Post>) {
-        event.entity.updatedColumns = event.updatedColumns.length;
+        if(event.entity) {
+            event.entity.updatedColumns = event.updatedColumns.length;
+        }
     }
 
     afterLoad(entity: Post) {