fix: typings for Repository.extend function (#9396)

additionally remove duplicated TreeRepository.extend method
typeorm · Dec 3, 2022 · f07fb2c · f07fb2c
1 parent d490793
commit f07fb2c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 21 deletions.
diff --git a/src/repository/Repository.ts b/src/repository/Repository.ts
@@ -627,9 +627,8 @@ export class Repository<Entity extends ObjectLiteral> {
      * Extends repository with provided functions.
      */
     extend<CustomRepository>(
-        custom: CustomRepository &
-            ThisType<Repository<Entity> & CustomRepository>,
-    ): Repository<Entity> & CustomRepository {
+        custom: CustomRepository & ThisType<this & CustomRepository>,
+    ): this & CustomRepository {
         // return {
         //     ...this,
         //     ...custom

diff --git a/src/repository/TreeRepository.ts b/src/repository/TreeRepository.ts
@@ -408,24 +408,6 @@ export class TreeRepository<
         throw new TypeORMError(`Supported only in tree entities`)
     }
 
-    /**
-     * Extends tree repository with provided functions.
-     */
-    extend<CustomRepository>(
-        custom: CustomRepository &
-            ThisType<TreeRepository<Entity> & CustomRepository>,
-    ): TreeRepository<Entity> & CustomRepository {
-        const thisRepo = this.constructor as new (...args: any[]) => typeof this
-        const { target, manager, queryRunner } = this
-        const cls = new (class extends thisRepo {})(
-            target,
-            manager,
-            queryRunner,
-        )
-        Object.assign(cls, custom)
-        return cls as any
-    }
-
     /**
      * Moves entity to the children of then given entity.
      *