fix: make OracleQueryRunner createDatabase if-not-exists not fail

typeorm · Jul 16, 2021 · f5a80ef · f5a80ef
1 parent 128b982
commit f5a80ef
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/src/driver/oracle/OracleQueryRunner.ts b/src/driver/oracle/OracleQueryRunner.ts
@@ -310,7 +310,24 @@ export class OracleQueryRunner extends BaseQueryRunner implements QueryRunner {
      * Creates a new database.
      */
     async createDatabase(database: string, ifNotExist?: boolean): Promise<void> {
-        await this.query(`CREATE DATABASE IF NOT EXISTS "${database}"`);
+        // Even with `IF NOT EXISTS` we get:
+        //   ORA-01501: CREATE DATABASE failed
+        //   ORA-01100: database already mounted
+        if (ifNotExist) {
+            try {
+                await this.query(`CREATE DATABASE IF NOT EXISTS "${database}";`);
+            } catch (e) {
+                if (e instanceof QueryFailedError) {
+                    if (e.message.includes("ORA-01100: database already mounted")) {
+                        return;
+                    }
+                }
+
+                throw e;
+            }
+        } else {
+            await this.query(`CREATE DATABASE "${database}"`);
+        }
     }
 
     /**