Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

there is no Unique decoration export in typeorm-model-shim #5920

Closed
j1i-ian opened this issue Apr 20, 2020 · 1 comment · Fixed by #6891
Closed

there is no Unique decoration export in typeorm-model-shim #5920

j1i-ian opened this issue Apr 20, 2020 · 1 comment · Fixed by #6891
Labels
new feature

Comments

@j1i-ian
Copy link

j1i-ian commented Apr 20, 2020 •
edited

Issue type:
[v] feature request

TypeORM version:
[v] latest

Hello, I'm developer who loves typeorm that holy powerful and super comfortable ORM framework since using Hibernate.

I found the error on my front-end when use typeorm-shims with @Unique decorators in entity.

typeorm shim.js is set on tsconfig. but after when I add @unique decoration, In my case, Angular framework throw webpack_imported_module _9_ default(...) is not a function error.

I was manually patching Unique fake function to typeorm-model-shim.js, then fixing this issue.

Can you add Unique for typeorm shims? Or How can I support for you?
I hope to help typeorm. Typeorm has insufficient features but the best on all javascript ORM. I'm totally fan of you.
@j1i-ian
Copy link
Author

j1i-ian commented Apr 20, 2020

Ah, It was error when I avoid using @Unique decorator in my entity.

When I configure @Unique to each columns in one Entity, typeorm was threw error.

So I have to set @Unique on model class ( next line of @Entity )

imnotjames added a commit to imnotjames/typeorm that referenced this issue Oct 11, 2020
@imnotjames
fix: sync the typeorm-model-shim
96eccec 
this updates the shim to include all current decorators
exported from index.ts - adding @unique and a few others

fixes: typeorm#6288
fixes: typeorm#5920
This was referenced Oct 11, 2020
Merged
Closed
pleerock pushed a commit that referenced this issue Oct 13, 2020
@imnotjames
fix: sync the typeorm-model-shim (#6891)
c72e48b 
this updates the shim to include all current decorators
exported from index.ts - adding @unique and a few others

fixes: #6288
fixes: #5920
zaro pushed a commit to zaro/typeorm that referenced this issue Jan 12, 2021
@imnotjames
fix: sync the typeorm-model-shim (typeorm#6891)
8b836b3 
this updates the shim to include all current decorators
exported from index.ts - adding @unique and a few others

fixes: typeorm#6288
fixes: typeorm#5920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sync the typeorm-model-shim imnotjames/typeorm
2 participants
@imnotjames @j1i-ian