Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complement shim.js : Is there any problem adding @Unique to shim ? #6288

Closed
j1i-ian opened this issue Jun 21, 2020 · 2 comments · Fixed by #6891
Closed

Complement shim.js : Is there any problem adding @Unique to shim ? #6288

j1i-ian opened this issue Jun 21, 2020 · 2 comments · Fixed by #6891
Labels
can be closed? new feature

Comments

@j1i-ian
Copy link

j1i-ian commented Jun 21, 2020

I've error on Angular 9 with TypeORM shim, and it is resolved with manually @unique empty patch.

If when I add @unique and something decorator empty function, will this be problem?

Issue type:
[x] feature request

TypeORM version:
[x] latest
@j1i-ian j1i-ian changed the title Is there any problem adding @Unique to shim ? Complement shim.js : Is there any problem adding @Unique to shim ? Jun 21, 2020
@imnotjames
Copy link
Contributor

You'll need to elaborate on your problem and what feature you're looking for - I'm not sure I understand what you'd like as a new behavior.

imnotjames added a commit to imnotjames/typeorm that referenced this issue Oct 11, 2020
@imnotjames
fix: sync the typeorm-model-shim
96eccec 
this updates the shim to include all current decorators
exported from index.ts - adding @unique and a few others

fixes: typeorm#6288
fixes: typeorm#5920
@imnotjames imnotjames mentioned this issue Oct 11, 2020
Merged
@imnotjames
Copy link
Contributor

Duplicate of #5920

@imnotjames imnotjames marked this as a duplicate of #5920 Oct 12, 2020
pleerock pushed a commit that referenced this issue Oct 13, 2020
@imnotjames
fix: sync the typeorm-model-shim (#6891)
c72e48b 
this updates the shim to include all current decorators
exported from index.ts - adding @unique and a few others

fixes: #6288
fixes: #5920
zaro pushed a commit to zaro/typeorm that referenced this issue Jan 12, 2021
@imnotjames
fix: sync the typeorm-model-shim (typeorm#6891)
8b836b3 
this updates the shim to include all current decorators
exported from index.ts - adding @unique and a few others

fixes: typeorm#6288
fixes: typeorm#5920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
can be closed? new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sync the typeorm-model-shim imnotjames/typeorm
2 participants
@imnotjames @j1i-ian