Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support column comments in Postgres and CockroachDB #6902

Merged
merged 1 commit into from
Oct 19, 2020
Merged

feat: Support column comments in Postgres and CockroachDB #6902

merged 1 commit into from
Oct 19, 2020

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Oct 13, 2020 •
edited

adds support for column comments to both the Postgres and
CockroachDB driver - for migrations & in metadata. also includes
new tests that validate the functionality works as expected

closes #4461
fixes #3360

@imnotjames
Copy link
Contributor Author

imnotjames commented Oct 13, 2020 •
edited

Actually, scratch this - I'm gonna open a separate PR that fixes the MySQL stuff first & adds the tests THEN I'll open this one. All set.

@imnotjames imnotjames marked this pull request as draft October 13, 2020 20:25
@imnotjames imnotjames force-pushed the feat/postgres-column-comments branch 2 times, most recently from 2971c12 to 39fd5fa Compare October 14, 2020 00:24
@imnotjames imnotjames mentioned this pull request Oct 14, 2020
Closed
@imnotjames imnotjames marked this pull request as ready for review October 18, 2020 16:42
@imnotjames
feat: Support column comments in Postgres and CockroachDB
69fb0c1 
adds support for column comments to both the Postgres and
CockroachDB driver - for migrations & in metadata.  also includes
new tests that validate the functionality works as expected

fixes typeorm#3360
@imnotjames imnotjames merged commit bc623a4 into typeorm:master Oct 19, 2020
@imnotjames imnotjames deleted the feat/postgres-column-comments branch October 19, 2020 16:46
@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 19, 2020
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
@imnotjames
feat: Support column comments in Postgres and CockroachDB (typeorm#6902)
18e2e6f 
adds support for column comments to both the Postgres and
CockroachDB driver - for migrations & in metadata.  also includes
new tests that validate the functionality works as expected

fixes typeorm#3360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted label hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setting COMMENT on columns and tables (PostgreSQL)
1 participant
@imnotjames