Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk insert returns for all values inserted the same row for Aurora Data API driver #7385

Closed
2 of 21 tasks
coyoteecd opened this issue Feb 17, 2021 · 0 comments · Fixed by #7434
Closed
2 of 21 tasks

Comments

@coyoteecd
Copy link
Contributor

Issue Description

This is a follow-up of #6668 and #5973; there we got a fix for MySQL driver, but not for the Aurora Data API driver (which is based off the MySQL driver). The behavior described there still reproduces with this driver.

Expected Behavior

When bulk-inserting records, e.g. via repository.insert(), the InsertResult should contain all the inserted identifiers in the identifiers array.

Actual Behavior

Only the first identifier is retrieved and the (unnecessary) SELECT done after the INSERT is using the same ID repeated over.

Steps to Reproduce

See #5973, but with Aurora Data API driver.

My Environment

Dependency Version
Operating System Windows 10
Node.js version v12.14.0
Typescript version v4.1.3
TypeORM version v0.2.31

Relevant Database Driver(s)

  • aurora-data-api
  • aurora-data-api-pg
  • better-sqlite3
  • cockroachdb
  • cordova
  • expo
  • mongodb
  • mysql
  • nativescript
  • oracle
  • postgres
  • react-native
  • sap
  • sqlite
  • sqlite-abstract
  • sqljs
  • sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time, and I know how to start.
  • Yes, I have the time, but I don't know how to start. I would need guidance.
  • No, I don't have the time, although I believe I could do it if I had the time...
  • No, I don't have the time and I wouldn't even know how to start.
coyoteecd added a commit to coyoteecd/typeorm that referenced this issue Feb 17, 2021
coyoteecd added a commit to coyoteecd/typeorm that referenced this issue Feb 19, 2021
coyoteecd added a commit to coyoteecd/typeorm that referenced this issue Feb 26, 2021
AlexMesser pushed a commit that referenced this issue Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant