Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (aurora-data-api) get correct increment primary key for multiple entities inserted #7434

Merged

Conversation

coyoteecd
Copy link
Contributor

Closes: #7385

Propagate the same fix that was done mysql to the Aurora Data API driver implementation.
This will make the InsertResult.identifiers property contain the correct IDs for bulk-inserts.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change (already fails on my machine in other places)
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change N/A
  • The new commits follow conventions explained in CONTRIBUTING.md

@AlexMesser AlexMesser merged commit fc8af5f into typeorm:master Mar 29, 2021
@AlexMesser
Copy link
Collaborator

thank you for contribution!

@coyoteecd coyoteecd deleted the fix-aurora-data-api-bulk-insert-ids branch January 6, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk insert returns for all values inserted the same row for Aurora Data API driver
2 participants