fix: entity
to be Partial<Entity> | undefined
in UpdateEvent
#7783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change was requested as part of #7724.
That change has made us realise that the type of
UpdateEvent.entity
is not strictly correct as justEntity
.UpdateEvent
in case of anupdate
, theentity
wasundefined
beforeUpdate
to be a PartialafterUpdate
subscriber #7724 this will be changed forafterUpdate
to be aPartial<Entity>
UpdateEvent
in case of asoft delete
, theentity
isundefined
This PR corrects the type for all scenarios which is
entity: Partial<Entity> | undefined
.I decided to split this out into a seperate PR from #7724 for a number of reasons:
afterUpdate
subscriberafterUpdate
subscriber #7724 is not.Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000
(N/A)