Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add serviceName option for oracle connections #8021

Merged

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Aug 4, 2021

Description of change

adds an explicit serviceName for connecting to oracle

fixes #8006

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@pleerock
Copy link
Member

pleerock commented Aug 4, 2021

Interesting, why it didn't execute CI tests 🤔

@imnotjames
Copy link
Contributor Author

Interesting, why it didn't execute CI tests thinking

Because I have CircleCI set up in my local repo it does for the commit but not for the PR when the commit ends up in the branch before the PR has been opened.

@imnotjames imnotjames merged commit 37bd012 into typeorm:master Aug 4, 2021
@imnotjames imnotjames deleted the feat/8006/oracle-service-name branch August 4, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createConnection throws ORA-12505 after TypeORM upgrade from 0.2.34 to 0.2.36
2 participants