fix: incorrect composite UNIQUE constraints detection
#8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
HeartPattern
pushed a commit
to HeartPattern/typeorm
that referenced
this pull request
Nov 29, 2021
* added fix and test for typeorm#8158 * fixed for other drivers * fixed column length for Oracle
HeartPattern
pushed a commit
to HeartPattern/typeorm
that referenced
this pull request
Nov 29, 2021
* added fix and test for typeorm#8158 * fixed for other drivers * fixed column length for Oracle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
See original issue for detailed description. This PR is based on #8157, but applies fix for all drivers and adds a test showing erroneous behavior.
Fixes #8158
Closes #8157
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000