Typeorm creates migration that creates already existing unique constraint #8157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #8158
Typeorm was detecting whether unique constraint exists on column by using
find()
on all constraints for column (finding one with typeUNIQUE
) and then checking whether the constraint is a composite one. This is not a valid approach, because in case there's more than one constraint for a column and the first one is composite the code will not detect the column is in fact unique.The code was adapted to use filter:
UNIQUE
This approach will correctly handle situation in which there are many unique keys for a column and some of them are composite and are ordered randomly.
Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000