Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.0: Transaction withRepository does not contain custom methods #8759

Closed
Q16solver opened this issue Mar 18, 2022 · 2 comments
Closed

0.3.0: Transaction withRepository does not contain custom methods #8759

Q16solver opened this issue Mar 18, 2022 · 2 comments
Labels

Comments

@Q16solver
Copy link
Contributor

Q16solver commented Mar 18, 2022

Issue Description

I had defined a custom function through extending:

image

But I cannot use it in transactions, I think this wasn't intended

image

The code seems like it just calls the original constructor which is probably why, I'm not quite sure if there's a good way to fix this

image

Expected Behavior

Transactional entity manager should have access to custom extended functions

Actual Behavior

Transactional entity manager only has access to builtin functions

My Environment

Dependency Version
Operating System
Node.js version x.y.zzz
Typescript version x.y.zzz
TypeORM version x.y.zzz

Additional Context

Relevant Database Driver(s)

DB Type Reproducible
aurora-mysql no
aurora-postgres no
better-sqlite3 no
cockroachdb no
cordova no
expo no
mongodb no
mysql no
nativescript no
oracle no
postgres yes
react-native no
sap no
sqlite no
sqlite-abstract no
sqljs no
sqlserver no

Are you willing to resolve this issue by submitting a Pull Request?

  • ✖️ Yes, I have the time, and I know how to start.
  • ✖️ Yes, I have the time, but I don't know how to start. I would need guidance.
  • ✅ No, I don’t have the time, but I can support (using donations) development. 5$
  • ✖️ No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.
@pleerock
Copy link
Member

fixed by #8764

@Q16solver
Copy link
Contributor Author

@pleerock Confirmed this is fixed in 0.3.1, donated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants