Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow hstore type to use transformers in driver postgres #8823

Conversation

devx-opensource
Copy link
Contributor

Description of change

The HSTORE type is the only type bypassing the transformer
column options.

This fix makes the option available to this column type as well.

If the current behavior was intentional then the documentation should be updated to inform developers that transformers are not applicable to the HSTORE type in Postgres.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000 N/A
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change N/A
  • The new commits follow conventions explained in CONTRIBUTING.md

The HSTORE type is the only type bypassing the transformer
column options.
This fix makes the option available to this column type as well.
@pleerock pleerock merged commit b1a0107 into typeorm:master Mar 30, 2022
@pleerock
Copy link
Member

Thank you for contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants