Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow hstore type to use transformers in driver postgres #8823

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/driver/postgres/PostgresDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -723,9 +723,7 @@ export class PostgresDriver implements Driver {
return ""
},
)
return object
} else {
return value
value = object
}
} else if (columnMetadata.type === "simple-array") {
value = DateUtils.stringToSimpleArray(value)
Expand Down
13 changes: 13 additions & 0 deletions test/other-issues/hstore-allow-transformer/entity/hstore-entity.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { Entity } from "../../../../src/decorator/entity/Entity"
import { Column } from "../../../../src/decorator/columns/Column"
import { PrimaryGeneratedColumn } from "../../../../src/decorator/columns/PrimaryGeneratedColumn"
import { testTransformer } from "../test-transformer"

@Entity()
export class DummyHSTOREEntity {
@PrimaryGeneratedColumn()
id: number

@Column({ type: "hstore", transformer: testTransformer })
translation: object
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import "../../utils/test-setup"
import {
createTestingConnections,
closeTestingConnections,
reloadTestingDatabases,
} from "../../utils/test-utils"
import { DataSource } from "../../../src"
import { expect } from "chai"
import { DummyHSTOREEntity } from "./entity/hstore-entity"

describe("other issues > allow HSTORE column type to use transformers", () => {
let connections: DataSource[]
before(
async () =>
(connections = await createTestingConnections({
entities: [__dirname + "/entity/*{.js,.ts}"],
schemaCreate: true,
dropSchema: true,
enabledDrivers: ["postgres"],
})),
)
beforeEach(() => reloadTestingDatabases(connections))
after(() => closeTestingConnections(connections))

it("should use the transformer set in the column options", () =>
Promise.all(
connections.map(async (connection) => {
const repository = connection.getRepository(DummyHSTOREEntity)

const translation = {
en_US: "hello",
fr_FR: "salut",
}

const dummy = repository.create({
translation,
})

await repository.save(dummy)

const dummyEntity = await repository.findOneByOrFail({
id: dummy.id,
})
expect(dummyEntity.translation).to.equal("hello")
}),
))
})
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
export const testTransformer = {
to(data: any) {
return data
},
from(data: any) {
return data.en_US
},
}