fix: Revert #10432 to fix issue with @VirtualColumn not being returned
#10777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b53e410.
|
@tolgap Please add the tests so that if your PR is accepted, there is some validation that the @VirtualColumn is being returned |
|
@macleysousa what are you talking about? Its a revert of my previous PR. This break should've been caught by the existing tests. But they haven't been running in CircleCI for months now which I also tried bringing up in that PR |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Makes #10698 obsolete, that PR has many unnecessary changes.
Fixes #10638
This will fix a bug caused by pull request #10432 that caused virtual columns to not be loaded. I reverted that merge in this PR.