Add vector support #10789
Open
Add vector support #10789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
firtoz
commented
Mar 24, 2024
| @@ -601,10 +601,22 @@ export class PostgresQueryRunner | |||
| downQueries.push(this.dropIndexSql(table, index)) | |||
| }) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
These were changed by npm run format
firtoz
commented
Mar 24, 2024
| @@ -459,10 +459,8 @@ export class InsertQueryBuilder< | |||
| // add VALUES expression | |||
| if (valuesExpression) { | |||
| if ( | |||
| ( | |||
| this.connection.driver.options.type === "oracle" || | |||
There was a problem hiding this comment.
These were changed by npm run format
firtoz
force-pushed
the
feat/vector
branch
4 times, most recently
from
6b8b07f
to
2b60ebf
Compare
|
It seems pgvector installation is a bit difficult with docker, got stuck here :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10056
Description of change
Based on #10138 - added more tests, the tests showed issues, fixed those issues.
The tests however require the pgvector extension set up for the server. On my machine I followed instructions from https://github.com/pgvector/pgvector - I don't know if the test runners are set up to support it? Can try to get it done if anyone can give me hints.
Also, when I did a
npm run formatit formatted some files I did not touch. I committed them here, can undo that if necessary.Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000