Extract function to generate migration #10796
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Typeorm relies on a static DataSource being created and exported. However, this does not play nice with code bases where this is not desirable.
To support generating migrations in such code bases, I extracted the function to generate migration in such a way that you can just pass in instance of DataSource to it along with other options. In this manner, we should be able to use
MigrationGenerateCommand.genMigration(...)
without having to go through Typeorm CLI that assumes static DataSource.Pull-Request Checklist
master
branchnpm run format
to apply prettier formattingnpm run test
passes with this changeFixes #0000