Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build ESM migrations for JS #10802

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Build ESM migrations for JS #10802

wants to merge 3 commits into from

Conversation

w3nl
Copy link

@w3nl w3nl commented Mar 28, 2024 •
edited

Including jsdoc for typehinting

Description of change

This will change the JS migration template to ESM compatible.
Fixes #10801
A non breaking solution where you can choose between ESM or CommonJS as generated migration.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #10801
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@w3nl w3nl force-pushed the master branch 2 times, most recently from f7625c2 to e004bb6 Compare March 28, 2024 11:40
@w3nl
fix: Build ESM migrations for JS
c0ffb24 
Including jsdoc for typehinting
Add esm as an option in the migrate cli
Update the documentation for the JS migrations

Closes: typeorm#10801
@w3nl w3nl mentioned this pull request Mar 28, 2024
Open
18 tasks
@w3nl
Copy link
Author

w3nl commented Mar 28, 2024

@pleerock Could you check this PR?
I see also that Oracle test failed, but it is a timeout

Too long with no output (exceeded 10m0s): context deadline exceeded

But I see more PR's have the same issue.

@w3nl
Copy link
Author

w3nl commented Apr 4, 2024

@NoNameProvided Could you check this PR?

@w3nl
Copy link
Author

w3nl commented Apr 12, 2024

@pleerock / @NoNameProvided / @AlexMesser / @imnotjames Could you check this PR?

@w3nl
Copy link
Author

w3nl commented Apr 18, 2024

Looks like TypeORM is dead...
No responses to this, also not from my personal email :(

@NoNameProvided
Copy link
Member

I am not a maintainer of TypeORM, I never was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated JS migrations in modern ESM format
2 participants
@w3nl @NoNameProvided