New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add multiSubnetFailover option for mssql #10804

Open

isaru66 wants to merge 1 commit into typeorm:master from isaru66:master

isaru66 commented Mar 28, 2024 •

edited

Description of change

add multiSubnetFailover option for SqlServerConnectionOptions.

This will support MSSQL alway on avalibility group to be failover faster

ref: https://learn.microsoft.com/en-us/sql/sql-server/failover-clusters/windows/sql-server-multi-subnet-clustering-sql-server?view=sql-server-ver16#DNS

in tediousjs this feature was implemented in tediousjs/tedious#362

Pull-Request Checklist

Code is up-to-date with the master branch
npm run format to apply prettier formatting
npm run test passes with this change
This pull request links relevant issues as Fixes #0000
There are new or updated unit tests validating the change
Documentation has been updated to reflect this change
The new commits follow conventions explained in CONTRIBUTING.md


          fix: add multiSubnetFailover option for mssql

d878b57

isaru66 mentioned this pull request

Does node-mssql support multiSubnetFailover? tediousjs/node-mssql#1619

Closed

rjminchuk commented May 1, 2024

re-run circleci test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment