Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Fix for #4820 #4821

Closed
wants to merge 2 commits into from
Closed

Proposed Fix for #4820 #4821

wants to merge 2 commits into from

Conversation

jf214
Copy link

@jf214 jf214 commented Sep 26, 2019

Including schema in table path for OracleDriver in EntityMetadata

@pleerock
Copy link
Member

as I know in oracle there is no real schema. There is a schema but is equal to user. If so then our schema related functionality might not work properly.

@jf214
Copy link
Author

jf214 commented Oct 18, 2019

So far, in my experience using Typeorm with Oracle, I have not had any issues with how schemas are treated by the library. It wasn't until I updated to latest that my queries ignored the schema I had defined in the entities, which caused my queries to fail in Oracle. I think it started with d8f1c81.

I tested my fix and it seems to work for Oracle. Though in hindsight, it isn't ideal because it doesn't address the issue for other driver types.

@kdi-1
Copy link

kdi-1 commented Oct 27, 2019

@jf214 I think in number 8 should be
import {OracleDriver} from "../driver/oracle/OracleDriver";

Copy link
Contributor

@imnotjames imnotjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs tests to confirm the behaviors

@kdi-1
Copy link

kdi-1 commented Nov 3, 2020

@imnotjames @jf214 I think this can be closed as fixed in #6673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants