Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Optimized version of EntityMetadata#compareIds() for the common case #5419

Merged
merged 5 commits into from May 18, 2020
Merged

perf: Optimized version of EntityMetadata#compareIds() for the common case #5419

merged 5 commits into from May 18, 2020

Commits on Feb 23, 2020

  1. perf: Optimized version of EntityMetadata#compareIds() for the common… 

    … case
    @njam
    njam committed Feb 23, 2020
    Copy the full SHA
    da8716c View commit details
    Browse the repository at this point in the history

  2. Extract compareIds() into OrmUtils and use it instead of `.deepCo… 

    …mpare()` where applicable
    @njam
    njam committed Feb 23, 2020
    Copy the full SHA
    4bd2e34 View commit details
    Browse the repository at this point in the history

  3. Use optimized path in compareIds() also when .id has type "number"

    @njam
    njam committed Feb 23, 2020
    Copy the full SHA
    7adc0ab View commit details
    Browse the repository at this point in the history

  4. Add return type to signature of deepCompare() and compareIds()

    @njam
    njam committed Feb 23, 2020
    Copy the full SHA
    f37d231 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. made a proper check

    @pleerock
    pleerock committed Feb 25, 2020
    Copy the full SHA
    44d4252 View commit details
    Browse the repository at this point in the history