Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Child entities not being saved correctly with cascade actions #6219

Merged
merged 2 commits into from Sep 4, 2020
Merged

fix: Child entities not being saved correctly with cascade actions #6219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae14e6
fix: Child entities not being saved correctly with cascade actions
ZBAGI Jun 6, 2020
d23e651
fixes tslint complains
ZBAGI Jun 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/metadata/EntityMetadata.ts
View file
Open in desktop
Expand Up @@ -700,14 +700,21 @@ export class EntityMetadata {
relations.forEach(relation => {
const value = relation.getEntityValue(entity);
if (Array.isArray(value)) {
value.forEach(subValue => relationsAndValues.push([relation, subValue, relation.inverseEntityMetadata]));
value.forEach(subValue => relationsAndValues.push([relation, subValue, this.getInverseEntityMetadata(subValue, relation)]));
} else if (value) {
relationsAndValues.push([relation, value, relation.inverseEntityMetadata]);
relationsAndValues.push([relation, value, this.getInverseEntityMetadata(value, relation)]);
}
});
return relationsAndValues;
}

private getInverseEntityMetadata(value: any, relation: RelationMetadata): EntityMetadata {
const childEntityMetadata = relation.inverseEntityMetadata.childEntityMetadatas.find(metadata =>
metadata.target === value.constructor
);
return childEntityMetadata ? childEntityMetadata : relation.inverseEntityMetadata;
}

// -------------------------------------------------------------------------
// Public Static Methods
// -------------------------------------------------------------------------
Expand Down