fix: resolve issues ora-00972:identifier is too long

[MuratGundes]

Use index instead of parameter name for make it shorter alias name.

Closes: #5067

[pleerock]

@imnotjames right now we have no idea if we can merge this small, but suspicious change because we have no oracle tests on CI running 😭

[imnotjames]

We can get them running - they weren't before because they were disabled & I think the Oracle image couldn't be pulled 'cause it's not free.

Happy to take a look at adding an oracle build to the mix - I was poking at it the other day but gave up because it just hasn't been running before.

I'll poke at it and update here + slack with more info.

[pleerock]

@imnotjames thanks a lot

[MuratGundes]

Thanks a lot guys! We will be appreciated.

[Rainson12]

merging this will be much appreciated it seems to be working for us and it seems like there is not other solution other than this to fix the issue with column& table names be longer than 30 characters. Its also not possible to shorten the column names as its a legacy system.

[imnotjames]

Just to quickly update this thread on the status of OracleDB CI --- I've refactored the CI to use docker-compise to start up services. This simplifies bringing in other services because they just need to be defined in docker compose like the others & can even be "private" corporate images like the OracleDB ones. https://github.com/imnotjames/typeorm/blob/build/remote-docker/ I'll be trying to get this in as a PR today. As an extended part of this I've added the client libraries (why would it need separate libraries like this? Licensing I assume..? Ugh..) for oracleDB as well as a docker compose service to start up oracle for us to run tests against it. However, currently running into an issue with oracle during the first test that gets run against it - I've got a feeling I've set it up to connect to the wrong SID? Unclear. QueryFailedError: ORA-24005: Inappropriate utilities used to perform DDL on AQ table SYSTEM.DEF$_AQCALL

…

On Thu, Aug 20, 2020, 03:11 Rainson12 ***@***.***> wrote: merging this will be much appreciated it seems to be working for us and it seems like there is not other solution other than this to fix the issue with column& table names be longer than 30 characters. Its also not possible to shorten the column names as its a legacy system. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6591 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAL2Z2K7SAVTROWHTV2OMX3SBTEBPANCNFSM4QE6L3BQ> .

[imnotjames]

Ok - issue with tests is that I had tried to spin up Oracle 11 - which typeorm doesn't support.

Still some issues with oracle either not being completely ready for tests or possibly crashing during the tests..

I'll continue on that some today.

[imnotjames]

Oracle tests seem to be working and they catch another spot where this happens -

typeorm/src/query-builder/SelectQueryBuilder.ts

Line 1864 in 2c90e1c

return `${distinctAlias}.${columnAlias} as "ids_${DriverUtils.buildColumnAlias(this.connection.driver, mainAliasName, primaryColumn.databaseName)}"`;

The column alias can end up being 30 characters long because of the ids_ prefix. I'd fixed it by replacing it with:

https://github.com/imnotjames/typeorm/blob/build/oracle/src/query-builder/SelectQueryBuilder.ts#L1865-L1871

Same thing ALSO happens with table aliases - but I don't have a great solution for that.. That's a more in depth set of refactorings:

typeorm/src/query-builder/SelectQueryBuilder.ts

Line 1421 in 6b7711d

const froms = this.expressionMap.aliases

Still - different issue from this which is related to the parameter names rather than the identifiers generated

[imnotjames]

Should this instead be done similar to aliases? if > some predetermined driver specific length, hash it?

Like

typeorm/src/driver/DriverUtils.ts

Lines 51 to 53 in 5516aca

	if (maxAliasLength && maxAliasLength > 0 && columnAliasName.length > maxAliasLength) {
	return hash(columnAliasName, { length: maxAliasLength });
	}

[imnotjames]

Also @MuratGundes please rebase against master - the tests for Oracle should run now :)

[imnotjames]

Hey @MuratGundes - I'm gonna open another PR with these changes - the commits will have you as the author, but will be rebased against master so the oracle tests will run!

[pleerock]

thank you @imnotjames it would be great if we can merge this one as fast as possible