Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: pass ids_ to alias builder to prevent length overflow #6624

Merged
merged 1 commit into from Sep 2, 2020
Merged

bugfix: pass ids_ to alias builder to prevent length overflow #6624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/query-builder/SelectQueryBuilder.ts
View file
Open in desktop
Expand Up @@ -1861,7 +1861,14 @@ export class SelectQueryBuilder<Entity> extends QueryBuilder<Entity> implements
const columnAlias = this.escape(DriverUtils.buildColumnAlias(this.connection.driver, mainAliasName, primaryColumn.databaseName));
if (!orderBys[columnAlias]) // make sure we aren't overriding user-defined order in inverse direction
orderBys[columnAlias] = "ASC";
return `${distinctAlias}.${columnAlias} as "ids_${DriverUtils.buildColumnAlias(this.connection.driver, mainAliasName, primaryColumn.databaseName)}"`;

const alias = DriverUtils.buildColumnAlias(
this.connection.driver,
"ids_" + mainAliasName,
primaryColumn.databaseName
);

return `${distinctAlias}.${columnAlias} as "${alias}"`;
});

rawResults = await new SelectQueryBuilder(this.connection, queryRunner)
Expand All @@ -1888,7 +1895,13 @@ export class SelectQueryBuilder<Entity> extends QueryBuilder<Entity> implements
}).join(" AND ");
}).join(" OR ");
} else {
const ids = rawResults.map(result => result["ids_" + DriverUtils.buildColumnAlias(this.connection.driver, mainAliasName, metadata.primaryColumns[0].databaseName)]);
const alias = DriverUtils.buildColumnAlias(
this.connection.driver,
"ids_" + mainAliasName,
metadata.primaryColumns[0].databaseName
);

const ids = rawResults.map(result => result[alias]);
const areAllNumbers = ids.every((id: any) => typeof id === "number");
if (areAllNumbers) {
// fixes #190. if all numbers then its safe to perform query without parameter
Expand Down