Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unnecessary migrations for unsigned numeric types #6632

Merged
merged 5 commits into from Sep 10, 2020
Merged

fix: Unnecessary migrations for unsigned numeric types #6632

merged 5 commits into from Sep 10, 2020

Commits on Aug 28, 2020

  1. fix: Unnecessary migrations for unsigned numeric types 

    In MariaDB, unsigned numeric types (``<tiny,small,medium>int`) without an explicit `width` property set would generate migrations on every run. This is due to an error in setting the default width for unsigned types.

Fixes typeorm#2943
    @michaelbromley
    michaelbromley committed Aug 28, 2020
    Copy the full SHA
    b6fef26 View commit details
    Browse the repository at this point in the history

  2. test: Enable all tests

    @michaelbromley
    michaelbromley committed Aug 28, 2020
    Copy the full SHA
    414a3fa View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. refactor: Move isDefaultColumnWidth() method out of BaseQueryRunner 

    See typeorm#6632 (review) for discussion as to why.
    @michaelbromley
    michaelbromley committed Sep 4, 2020
    Copy the full SHA
    4382d2b View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. fix: Correct unsigned int behaviour for MySQL 5.7

    @michaelbromley
    michaelbromley committed Sep 9, 2020
    Copy the full SHA
    8a0fb4d View commit details
    Browse the repository at this point in the history

  2. fix: Correct position of zerofill check 

    Plus stylistic change based on code review
    @michaelbromley
    michaelbromley committed Sep 9, 2020
    Copy the full SHA
    71fb286 View commit details
    Browse the repository at this point in the history