Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Migration issues with scale & precision in sqlite/sql.js #6638

Merged
merged 3 commits into from Sep 3, 2020
Merged

fix: Migration issues with scale & precision in sqlite/sql.js #6638

merged 3 commits into from Sep 3, 2020

Commits on Aug 28, 2020

  1. fix: Migration issues with scale & precision in sqlite/sql.js 

    Specifying precision or scale properties on columns with SQLite/sql.js would result in migrations being generated even on an unchanged schema.

This was due to the precision and scale arguments not correctly being inferred when reading the table. This change handles scale and precision in the same way that "length" was already being correctly handled.

Fixes typeorm#6636
    @michaelbromley
    michaelbromley committed Aug 28, 2020
    Copy the full SHA
    27e5ad6 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. awaited the test

    @pleerock
    pleerock committed Sep 3, 2020
    Copy the full SHA
    a1f3ef4 View commit details
    Browse the repository at this point in the history

  2. fix missing async

    @pleerock
    pleerock committed Sep 3, 2020
    Copy the full SHA
    1a0d093 View commit details
    Browse the repository at this point in the history