Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: count() method for multiple primary keys for cockroachdb #6745

Merged
merged 5 commits into from Sep 21, 2020
Merged

fix: count() method for multiple primary keys for cockroachdb #6745

merged 5 commits into from Sep 21, 2020

Commits on Sep 19, 2020

  1. fix: count() method for multiple primary keys for cockroachdb 

    Cockroachdb does not support concat() for different types at the moment.
To fix this problem, each primary key is cast to the text type.
    @temnov98
    temnov98 committed Sep 19, 2020
    Copy the full SHA
    4e31ba0 View commit details
    Browse the repository at this point in the history

  2. fix: add doublequote

    @temnov98
    temnov98 committed Sep 19, 2020
    Copy the full SHA
    758d858 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2020

  1. fix: add doublequote

    @temnov98
    temnov98 committed Sep 20, 2020
    Copy the full SHA
    f36e942 View commit details
    Browse the repository at this point in the history

  2. test: update and move tests for count() method for multiple primary keys

    @temnov98
    temnov98 committed Sep 20, 2020
    Copy the full SHA
    e3df5d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. fix: count() method for multiple primary keys for oracle 

    Oracle does not support CONCAT() for more than 2 arguments at the moment.
To solve this problem, operator || is used instead of CONCAT().
    @temnov98
    temnov98 committed Sep 21, 2020
    Copy the full SHA
    246670b View commit details
    Browse the repository at this point in the history